Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3051: Modernized unit tests #1171

Merged
merged 1 commit into from
Apr 4, 2021
Merged

Conversation

thiru-mg
Copy link
Contributor

@thiru-mg thiru-mg commented Apr 3, 2021

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason: no new functionality, only refactroing

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@thiru-mg thiru-mg requested a review from RyanSkraba April 3, 2021 04:40
@thiru-mg thiru-mg self-assigned this Apr 3, 2021
@github-actions github-actions bot added the C++ Pull Requests for C++ binding label Apr 3, 2021
@thiru-mg thiru-mg changed the title Modernized unit tests AVRO-3051: Modernized unit tests Apr 3, 2021
@thiru-mg thiru-mg merged commit 8a5774b into apache:master Apr 4, 2021
@thiru-mg thiru-mg deleted the thiru_AVRO-3051-8 branch April 4, 2021 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Pull Requests for C++ binding
Projects
None yet
1 participant