Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVRO-3149: Add Rust based Implementation of Avro #1234
AVRO-3149: Add Rust based Implementation of Avro #1234
Changes from all commits
7741c90
fe7838a
797622f
5931c2a
fa255e0
f1220e8
221c5eb
22fbfcf
e66a1a6
54ee76c
8dcefe7
9429baf
0ece0eb
40abec8
8340007
e34c2d4
523eda8
d78d679
cc5eea1
c2ee646
259f6a4
0a6d68b
a0e36c2
b62c916
8a17afe
02ad501
62ac563
279a6fb
b6cb9b6
4418664
3ea6c20
e09f5d6
f22501f
26815f5
85bc4e3
7490170
cf3bf1a
571076f
e2e61dd
9dc1db0
0a0a66a
90cff7e
402180d
ef930cc
65e2658
229830b
8d008e5
4185526
2ecd3aa
79c3bf5
8135e24
7dada20
df4e8be
b2ca48b
c2c9f25
22f7ecf
c87fe92
662faf9
1004141
df94ea7
5932ae7
5554c4a
3dfff91
1c22ea7
f102828
b77f77c
db89414
e881e83
39dd1ee
cc55d86
738fa3b
d6e9c79
deca059
69b1023
c0c7a34
faadbc4
aee5164
2baa511
5dde3b5
b4138d0
90a6498
f1434f0
520d2ce
ef8878d
04f82c2
c3a19a2
c94cbb0
d39cc23
372b548
8b0df4c
2660a8b
6a036fc
3b822b6
d053b29
1860c70
c7942e4
57bc8c6
260d189
e5c6c55
e35eb56
cebc498
c3a97bb
9bf2365
1130001
fe68328
227940c
37ea688
35d2108
10ea827
2fc8d9d
29f318b
9492d6c
1afc3d9
7b820c1
aa1cb56
9e6b18f
e5ca80b
06a1b01
c4971ac
3a93d16
652b233
af04ed8
ffede29
c9f62a1
3417ccd
183893e
7c72554
173e4c5
0bcb437
3336bd1
1f8af33
4e89943
f7f03f3
9837a4d
3d774b9
85d8c45
7a80378
f679ac7
83baa43
4c184f6
1a9d3ae
9589175
86b4587
5acbfbf
477c71e
5b7e52e
d7aa0a8
d043d23
f343383
1988598
7395db8
606ba8d
e1cffc5
da3580e
45c941d
c1fc9df
ce7c710
df61e8a
3fb71e0
72c0ffc
9592038
656db36
d841c04
69807e9
7a87b53
d3f3c6e
d719de2
95ae8d2
6c3b4cd
b3edfac
743a6df
4aae22d
8249051
a89d82e
0ca45b4
c2dbe43
2e24700
389e5ea
2817b09
9eebe82
f59297f
1b3e973
9d99073
1e16824
9a42a2b
226ba8a
318cb46
9076770
4e372de
d5b1970
d5179c3
de6153e
f28acbb
5d97f28
d8299dc
9c248bd
8c02574
eef23fc
f0c2ac2
8e5a8ef
941000b
88a6014
7f15e3d
f84c53c
e80bd25
8cf8e70
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't
VIRTUAL_ENV
a python-specific environment variable? Does the rust build system work within a python ecosystem?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a tool to automatically install and activate the virtualenv where pre-commit hooks live without having to do it manually. This for the quality of life of the developers, but it isn't necessary for the project to build at all. You can safely remove it, if you don't want to use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should either put .pre-commit-config.yaml at the repo root, or ensure that it can apply different config files to different lang trees…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I would like to introduce pre-commit to lang/py as well, if not everything.)