AVRO-3221: Verify NUL termination on set_string_len and make buffer more compact #1352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously all
size
bytes were copied from the given string,including the required NUL terminator, and then another NUL terminator
was appended in avro_raw_string_set_length.
Now the existence of the NUL terminator is verified, allowing to
catch programmer mistakes and then only
size
- 1 bytes are copiedbefore appending the NUL terminator.
Make sure you have checked all steps below.
Jira
Tests
Test that setting a non-null terminated string fails.
Commits