Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3395: Updated DataFileWriter to meet styling guidelines #1542

Closed
wants to merge 8 commits into from

Conversation

KyleSchoonover
Copy link
Contributor

Jira

Tests

  • My PR does not need testing for this extremely good reason: non functional changes

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@netlify
Copy link

netlify bot commented Feb 14, 2022

❌ Deploy Preview for avro-website-preview failed.

🔨 Explore the source changes: 15e96d1

🔍 Inspect the deploy log: https://app.netlify.com/sites/avro-website-preview/deploys/6209d22d60ef2c0008dd1810

@github-actions github-actions bot added the C# label Feb 14, 2022
@RyanSkraba RyanSkraba changed the title AVRO-3395 Updated DataFileWriter to meet styling guidelines AVRO-3395: Updated DataFileWriter to meet styling guidelines Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant