AVRO-1542 replacing auto_ptr by unique_ptr & std::move #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request. It looks good, but it makes new requirement that the compiler should support C++11, which we didn't have thus far. Since we already have a dependency on Boost and Boost has been having unique_ptr for a long time, instead of using std::unique_ptr if we use boost::unique_ptr, we won't be causing new incompatibility. Do you want to make such a change? |
|
I am afraid I wont be able to get to this anytime soon. |
|
Since #203 has been opened to address followup comments can this PR be closed? |
iemejia
referenced
this pull request
in iemejia/avro
May 24, 2021
* Implement the Rabin fingerprint algorithm * Fix use formatting * Update documentation, make the rabin module public * Update the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify
all tests passed in my local build