Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3440: Fix bug in Protocol.createMessage #1586

Merged
merged 2 commits into from Mar 10, 2022

Conversation

opwvhk
Copy link
Contributor

@opwvhk opwvhk commented Mar 8, 2022

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    org.apache.avro.TestProtocol#testCopyMessage

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@github-actions github-actions bot added the Java Pull Requests for Java binding label Mar 8, 2022
@RyanSkraba RyanSkraba self-requested a review March 9, 2022 16:50
Copy link
Contributor

@RyanSkraba RyanSkraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch for an obvious mistake!

@RyanSkraba RyanSkraba merged commit 8e11c61 into apache:master Mar 10, 2022
RyanSkraba pushed a commit that referenced this pull request Mar 10, 2022
* AVRO-3440: Fix bug in Protocol.createMessage

* AVRO-3440: Spotless
@opwvhk opwvhk deleted the AVRO-3440-bug-Protocol-createMessage branch September 26, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java Pull Requests for Java binding
Projects
None yet
2 participants