Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVRO-3536: Inherit conversions for Union type #1721

Merged
merged 7 commits into from Nov 16, 2022
Merged

AVRO-3536: Inherit conversions for Union type #1721

merged 7 commits into from Nov 16, 2022

Conversation

im-pratham
Copy link
Contributor

Updated the getForSchema to also consider Union types

@github-actions github-actions bot added the Java Pull Requests for Java binding label Jun 15, 2022
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 20, 2022
View reviewed changes
lang/java/avro/src/test/java/org/apache/avro/specific/TestUnionRecord.java

// Used by DatumReader. Applications should not call.
@SuppressWarnings(value = "unchecked")
public void put(int field$, Object value$) {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [IndexedRecord.put](1); it is advisable to add an Override annotation.
lang/java/avro/src/test/java/org/apache/avro/specific/TestUnionRecord.java Show resolved Hide resolved
lang/java/avro/src/test/java/org/apache/avro/specific/TestUnionRecord.java Show resolved Hide resolved
lang/java/avro/src/test/java/org/apache/avro/specific/TestUnionRecord.java Show resolved Hide resolved
@KalleOlaviNiemitalo KalleOlaviNiemitalo mentioned this pull request Jul 2, 2022
Open
@mluiten
Copy link

mluiten commented Oct 7, 2022

Any updates on when this will be merged? Seems like it's good to go and it's a really unexpected and annoying bug.

nandorKollar
nandorKollar approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@nandorKollar nandorKollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nandorKollar nandorKollar merged commit 000338a into apache:master Nov 16, 2022
RyanSkraba pushed a commit that referenced this pull request Nov 17, 2022
@im-pratham @RyanSkraba
AVRO-3536: Inherit conversions for Union type (#1721)
4819a33 
* AVRO-3536: Inherit conversions for Union type

* AVRO-3536: Inherit conversions for Union type

* AVRO-3536: added test cases

* AVRO-3536: fix RAT failure

* AVRO-3536: generated new class with @OverRide annotation
@MosheElisha
Copy link

Thanks for the fix! When can we expect a release (avro and avro-maven-plugin) with the fix?

@Abheeshskurup
Copy link

facing same issue ... if there is a fix already in place ..please share the version

@anleib
Copy link

anleib commented Mar 23, 2023

Just got hit by this issue as well. When can we expect this to be released?

@AmsterdamFilho
Copy link

When will this be released?

@martin-g
Copy link
Member

martin-g commented Nov 7, 2023

It has been released with 1.11.2

@hmsantos
Copy link

Tried updating the sample provided on https://issues.apache.org/jira/browse/AVRO-3536 to use release 1.11.3 and it still fails, is something else needed?

@martin-g
Copy link
Member

In that case the best would be to open a new JIRA ticket and send a PR with the failing test/sample (and a fix if you know how to fix it).
AFAIS this PR has been merged to both main (1.12.0) and branch-1.11 (for 1.11.2) but I haven't looked deeper what is in the sample and what is in the PR changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opwvhk opwvhk opwvhk left review comments

@KalleOlaviNiemitalo KalleOlaviNiemitalo KalleOlaviNiemitalo left review comments

@nandorKollar nandorKollar nandorKollar approved these changes

Assignees
No one assigned
Labels
Java Pull Requests for Java binding
Projects
None yet
Milestone
No milestone