Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3553: Limit changes to rubocop lint #1741

Merged
merged 1 commit into from Jun 29, 2022

Conversation

RyanSkraba
Copy link
Contributor

Make sure you have checked all steps below.

Jira

Tests

  • My PR does not need testing for this extremely good reason: fixing a build failure.

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@github-actions github-actions bot added the Ruby label Jun 28, 2022
@RyanSkraba
Copy link
Contributor Author

I'm going to merge this as-is to unblock the build!

@RyanSkraba RyanSkraba merged commit 903fa84 into apache:master Jun 29, 2022
@tjwp
Copy link
Contributor

tjwp commented Jun 29, 2022

Sorry I didn't see this earlier. I think this other fix would have been to remove these lines from .rubocop.yml: https://github.com/apache/avro/blob/master/lang/ruby/.rubocop.yml#L54-L55

I can file an issue to remove the version restriction on the main branch. This is okay for the 1.11.1 release as it affects development.

@RyanSkraba RyanSkraba deleted the rskraba/AVRO-3553-rubocop-lint branch June 29, 2022 12:46
@RyanSkraba
Copy link
Contributor Author

Thanks @tjwp! Is there any value to adding the Gemspec/DeprecatedAttributeAssignment rule?

I'm still going to have to learn a bit more ruby one day :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants