Improve generated comments and compiler option description #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
approved these changes
Oct 27, 2022
martin-g
pushed a commit
that referenced
this pull request
Oct 27, 2022
* Fix indentation of comments on optional getter methods * Fix description comment on gettersReturnOptional (cherry picked from commit 50a12a3)
|
Thank you, @milindmantri ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
I was trying out Optionals and was looking at the code for the same. I've put up minor improvements. Hope it helps.
This is how it looked earlier,
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation