[fix] get/set defaults for fixed. #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacharya
requested changes
Feb 7, 2017
|
|
||
|
|
||
| @Test | ||
| public void testFixedDefaultValueDrop() { |
There was a problem hiding this comment.
The code looks good to me.
My concerns are with the tests.
Why is this a new class and not merged into SchemaBuilder?
There was a problem hiding this comment.
The main reason I created a separate unit test is that the issue is not only in the schema builder, it is also in the JacksonUtils.java...
asfgit
pushed a commit
that referenced
this pull request
Feb 28, 2017
closes #194. Signed-off-by: Thiruvalluvan M G <thiru@startsmartlabs.com>
zolyfarkas
added a commit
to PIMCO/avro
that referenced
this pull request
May 1, 2017
closes apache#194. Signed-off-by: Thiruvalluvan M G <thiru@startsmartlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a potential fix for this issue.