Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avro-1999: Java - Specify license in pom #195

Closed
wants to merge 1 commit into from

Conversation

benmccann
Copy link

My company uses tools that automatically check the licenses of libraries we use as specified in their poms. This change would make it much easier for us to use Avro. The vast majority of libraries we use specify their licenses in the pom, but Avro has to go through a special approval process anytime we want to upgrade the version we use.

@benmccann benmccann changed the title Specify license in pom Avro-1999: Java - Specify license in pom Feb 8, 2017
<licenses>
<license>
<name>Apache License, Version 2.0</name>
<url>http://www.apache.org/licenses/LICENSE-2.0</url>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to make this http://www.apache.org/licenses/LICENSE-2.0.txt
You want a text file and not an HTML file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@spacharya
Copy link
Contributor

spacharya commented Feb 9, 2017

@busbey Do we need to add the license any where else too?

@busbey
Copy link
Contributor

busbey commented Feb 9, 2017

we should be getting this for free by using the ASF parent pom. lemme see if we're not using that.

@busbey
Copy link
Contributor

busbey commented Feb 9, 2017

yeah, our top level pom specifies:

  <parent>
    <groupId>org.apache</groupId>
    <artifactId>apache</artifactId>
    <version>10</version>
  </parent>

and the apache pom v10 gives

 <licenses>
    <license>
      <name>The Apache Software License, Version 2.0</name>
      <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
      <distribution>repo</distribution>
    </license>
  </licenses>

So if we're still getting pinged in this tool we're either missing something in our chain of parent poms or the tool isn't properly honoring parent poms.

@benmccann
Copy link
Author

Ah, maybe our import tool isn't working for some reason. It does look like it should be coming from the ASF parent pom. I guess I'll close this for now then. Thanks for taking a look

(btw, there's a newer ASF parent pom. the v10 being used is 5yrs old. maybe worth updating to the newer v18)

@benmccann benmccann closed this Feb 9, 2017
@spacharya
Copy link
Contributor

I ran a complete build, and the license is getting pulled.
@benmccann can you tell more about the complain your tool is producing?

@spacharya
Copy link
Contributor

I guess I was too late, in my comment.
Never mind the earlier comment.

@busbey
Copy link
Contributor

busbey commented Feb 9, 2017

(btw, there's a newer ASF parent pom. the v10 being used is 5yrs old. maybe worth updating to the newer v18)

I would love an update to our parent pom. It would likely need to be a 1.9 change since it'll move around dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants