AVRO-3709: [Rust] Add aliases to record fields #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Use String instead of Alias. Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
|
@woile Please review this PR and test the branch! Thank you! |
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
force-pushed
the
avro-3709-add-aliases-to-record-fields
branch
from
fc39fae
to
a33f2db
Compare
|
Thank you Martin, I'll review tomorrow morning (CET) |
woile
reviewed
Feb 9, 2023
| .map(|alias| Alias::new(alias).expect("Alias is not valid")) | ||
| .collect::<Vec<Alias>>() | ||
| .map(|alias| alias.to_string()) | ||
| .collect::<Vec<String>>() |
There was a problem hiding this comment.
Where did you find the information about Aliases not requiring namespaces for RecordField? I was using the same alias parser to parse an Enum for example, but they now have different signature, it's not really a problem, but in the spec the text is the same for Enum and for RecordField
There was a problem hiding this comment.
Named schema's aliases are for the schema's name which might be namespaced.
Record field's aliases are for the field's name which is not namespaced. The field's type might be a (namespaced) reference to Schema.
|
It works on my project 👍🏻 |
martin-g
added a commit
that referenced
this pull request
Feb 9, 2023
* AVRO-3709: [Rust] Add 'aliases' field to RecordField * AVRO-3709: [Rust] Add support for serializing RecordField's aliases * AVRO-3709: [Rust] Record field's aliases don't have namespace Use String instead of Alias. * AVRO-3709: [Rust] Add support for field aliases in avro_derive --------- Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org> (cherry picked from commit a512fa2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVRO-3709
What is the purpose of the change
Adds support for Record field aliases
Verifying this change
Old tests are updated.
New tests are added.
Documentation