AVRO-2022: Allow schema as identifier in IDL (1.7)
#211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikvanoosten
changed the title
schema as identifier (1.7)schema as identifier in IDL (1.7)
erikvanoosten
changed the title
schema as identifier in IDL (1.7)schema as identifier in IDL (1.7)
|
After working with this change for some time we decided to abandon this idea and change the schema after all. The problem is that much code generation tools assume they can create method |
SingingBush
pushed a commit
to SingingBush/avro
that referenced
this pull request
Jun 29, 2023
Add 'additionalVelocityTool' capability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the word
schemais not allowed as identifier in IDL, even not when it is escaped in backticks. This patch fixed that for the 1.7 branch.