AVRO-3835: [Rust] Get rid of byteorder and zerocopy dependencies #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
force-pushed
the
avro-3835-get-rid-of-byteorder-and-zerocopy
branch
from
70c6f81
to
e02a65b
Compare
clesaec
approved these changes
Aug 18, 2023
lang/rust/avro/src/codec.rs
Outdated
| let mut encoded: Vec<u8> = vec![0; snap::raw::max_compress_len(stream.len())]; | ||
| let compressed_size = snap::raw::Encoder::new() | ||
| .compress(&stream[..], &mut encoded[..]) | ||
| .map_err(Error::SnappyCompress)?; | ||
| encoded.truncate(compressed_size); |
There was a problem hiding this comment.
As we know we will add u32 checksum, wouldn't it be more efficient with
encoded.truncate(compressed_size + 4);
There was a problem hiding this comment.
Good suggestion! Thanks!
| @@ -28,83 +24,77 @@ pub struct Duration { | |||
| } | |||
|
|
|||
| #[derive(Debug, Copy, Clone, Eq, PartialEq)] | |||
| pub struct Months(U32<LittleEndian>); | |||
| pub struct Months(u32); | |||
There was a problem hiding this comment.
Strange duration concept, that is not even Comparable, and Eq is false between 1 month, 0 day and 0 months 30 days ... And some month are 31 days ...
But this PR indeed enhance this.
There was a problem hiding this comment.
The implementation is per the spec - https://avro.apache.org/docs/1.11.1/specification/#duration
Use standard APIs for converting integers to/from byte arrays. Get rid of byteorder and zerocopy dependencies. Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
force-pushed
the
avro-3835-get-rid-of-byteorder-and-zerocopy
branch
from
e02a65b
to
954a527
Compare
martin-g
added a commit
that referenced
this pull request
Aug 18, 2023
RanbirK
pushed a commit
to RanbirK/avro
that referenced
this pull request
May 13, 2024
…che#2455) Use standard APIs for converting integers to/from byte arrays. Get rid of byteorder and zerocopy dependencies. Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use standard APIs for converting integers to/from byte arrays. Get rid of byteorder and zerocopy dependencies.
What is the purpose of the change
byteorderandzerocopydependencies with standard APIsVerifying this change
Documentation