Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3874: Bump minimum Newtonsoft version #2523

Closed
wants to merge 1 commit into from
Closed

AVRO-3874: Bump minimum Newtonsoft version #2523

wants to merge 1 commit into from

Conversation

zcsizmadia
Copy link
Contributor

What is the purpose of the change

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions bot added the C# label Sep 25, 2023
@zcsizmadia zcsizmadia changed the title Bump minimum Newtonsoft version AVRO-3874: Bump minimum Newtonsoft version Sep 25, 2023
@KalleOlaviNiemitalo
Copy link

A similar change was rejected in #1160. Even if Apache.Avro depends on a lower version of Newtonsoft.Json, applications that use it can add a direct dependency on the latest version.

Would the stack overflow be exploited via a malicious schema, or via malicious data? If the latter, then I don't think just upgrading Newtonsoft.Json will suffice, as PreresolvingDatumReader<T> also works recursively and does not seem to implement any depth limits.

@zcsizmadia
Copy link
Contributor Author

zcsizmadia commented Sep 26, 2023

That pr was rejected IMO before the severe vulnerability was discovered.I think this bump needs to happen because of the high severity of the issue. The new NET 8 compiler will warn about using the vulnerable version.

@zcsizmadia zcsizmadia closed this Nov 22, 2023
@zcsizmadia zcsizmadia deleted the avro-3874-bump-newtonsoft-version branch November 22, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants