AVRO-2956: [java] add reserved word escape character to the end of reserved and contextual keywords #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and contextual keywords.
|
Looks like the Python check failed due to failure to download bzip which seems unrelated to my changes. I went ahead and sync'ed my branch with main. |
|
@stephenkittelson can you fix the conflicts? |
Looks like Kyle Carter's PR 1527 that was merged earlier today fixed the same issue this PR was going to fix, so this PR is no longer necessary. Thanks for taking a look Fokko! |
|
@stephenkittelson Thanks, anyway, thank you for working on this! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull requests fixes deserialization of schemas with Java reserved and contextual keywords as field names which fixes AVRO-2956.
Verifying this change
This change can be verified with the added unit tests that validate deserialization adds the reserved word escape character to the end of class names that match reserved words or contextual keywords.
Documentation