Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3889: [Java][Build] Maven IDL Generation Modification Check #2561

Merged
merged 1 commit into from Jan 3, 2024

Conversation

briancullen
Copy link
Contributor

What is the purpose of the change

This change adds an up to date check to the maven plugin when generating Java classes from avro IDL. The reason for the change is to prevent unnecessary recompilation of the java source code in projects using the plugin.

Verifying this change

This change added tests and can be verified as follows:

  • Added tests to verify that only missing files are regenerated when processing the avro IDL files.
  • Altered existing tests to ensure that files are generated and not used from previous test runs.

Not sure if there are other scenarios that may be affected by this change.

Documentation

This pull request does not introduce a new feature and is not documented.

Check if the IDL source file has changed before regenerating the Java
classes to prevent unnecessary recompilation when using maven.
@github-actions github-actions bot added the Java Pull Requests for Java binding label Oct 22, 2023
@briancullen
Copy link
Contributor Author

@opwvhk forgive the question but I’m not sure what the process for this project is. Is it ok for me to merge now and should I make the equivalent PR for master?

@martin-g
Copy link
Member

martin-g commented Oct 23, 2023

@briancullen Can you see the Squash and merge button ?

@briancullen
Copy link
Contributor Author

@martin-g actually no, now that you mention it, I can't see a merge button. Presumably as I don't have write access to the repository. I should have probably looked before I asked, sorry.

@martin-g
Copy link
Member

No worries! The PR will be merged soon! Definitely before the next release!

@briancullen
Copy link
Contributor Author

@martin-g thanks for the feedback. Not sure if you wanted it but I created a similar pull request for the main branch and linked it to this (see #2564). Feel free to merge if you feel it is useful.

@briancullen
Copy link
Contributor Author

@martin-g Just to follow up on this. Can this pull request, and possibly #2564, be merged? Also, out of curiosity, is there any timeline for when there might be another release?

@martin-g
Copy link
Member

martin-g commented Jan 3, 2024

Hi @briancullen !

I maintain the Rust SDK.
But I see that @opwvhk (a Java developer!) already approved this PR, so I can merge it for you!

About the release: you can follow this discussion at dev@avro.apache.org - https://lists.apache.org/thread/sfmpn6dmrfpv4169tqx4klbw2dyqmz3z

@martin-g martin-g merged commit 0a2323f into apache:branch-1.11 Jan 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java Pull Requests for Java binding
Projects
None yet
4 participants