AVRO-3900: [Rust] Make it possible to use custom names validators #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP TODO: - Extract validators for enum symbols and record field names - Polish the APIs Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
force-pushed
the
avro-3900-custom-name-validators
branch
from
5b9df53
to
75232b8
Compare
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
This way they use the public APIs of the crate, as a real user application. Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
force-pushed
the
avro-3900-custom-name-validators
branch
from
899bf7d
to
c03e506
Compare
martin-g
force-pushed
the
avro-3900-custom-name-validators
branch
4 times, most recently
from
d62395d
to
7a018de
Compare
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
force-pushed
the
avro-3900-custom-name-validators
branch
from
7a018de
to
c277f41
Compare
Otherwise there are timing issues with the initializations of the OnceLock's for the different validators. Parsing a Schema leads to initialization of the default validator and later it is impossible to set a custom one Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
…test_helper crate For some reason clearing the log messages in the tests destructor (#[dtor]) was failing for this example. Simplify the TestLogger to use the std thread_local!() instead of the third party ref_thread_local!() Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
force-pushed
the
avro-3900-custom-name-validators
branch
3 times, most recently
from
eeb2b47
to
1dfe9f5
Compare
Just make sure the setup of the custom validators is done before the parsing of any schema to prevent registering the default validator (SpecificationValidator) Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
force-pushed
the
avro-3900-custom-name-validators
branch
from
1dfe9f5
to
86c70b3
Compare
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
changed the title
|
This worked on my machine (both |
|
I was waiting for a feedback from the reporter (@jslusher). |
|
@martin-g Hi! @rodneykeeling is a colleague of mine who was kind enough to test this branch in a new Rust consumer he's making. If he says it works, then we're good to go. Thanks for putting this together! |
martin-g
added a commit
that referenced
this pull request
Jan 25, 2024
) * AVRO-3900: [Rust] Make it possible to use custom validators * AVRO-3900: Add validator trait for enum symbol names * AVRO-3900: Introduce validator for RecordField's name * AVRO-3900: Extract the custom validators tests as IT tests This way they use the public APIs of the crate, as a real user application. * AVRO-3900: Polish APIs * AVRO-3900: Split the validator integration tests Otherwise there are timing issues with the initializations of the OnceLock's for the different validators. Parsing a Schema leads to initialization of the default validator and later it is impossible to set a custom one * AVRO-3900: Simplify generate_interop_data.rs example to not use avro_test_helper crate For some reason clearing the log messages in the tests destructor (#[dtor]) was failing for this example. Simplify the TestLogger to use the std thread_local!() instead of the third party ref_thread_local!() * AVRO-3900: Merge the validators integration tests in one test Just make sure the setup of the custom validators is done before the parsing of any schema to prevent registering the default validator (SpecificationValidator) * AVRO-3900: Improve the documentation Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org> (cherry picked from commit 61df187)
RanbirK
pushed a commit
to RanbirK/avro
that referenced
this pull request
May 13, 2024
…ache#2643) * AVRO-3900: [Rust] Make it possible to use custom validators * AVRO-3900: Add validator trait for enum symbol names * AVRO-3900: Introduce validator for RecordField's name * AVRO-3900: Extract the custom validators tests as IT tests This way they use the public APIs of the crate, as a real user application. * AVRO-3900: Polish APIs * AVRO-3900: Split the validator integration tests Otherwise there are timing issues with the initializations of the OnceLock's for the different validators. Parsing a Schema leads to initialization of the default validator and later it is impossible to set a custom one * AVRO-3900: Simplify generate_interop_data.rs example to not use avro_test_helper crate For some reason clearing the log messages in the tests destructor (#[dtor]) was failing for this example. Simplify the TestLogger to use the std thread_local!() instead of the third party ref_thread_local!() * AVRO-3900: Merge the validators integration tests in one test Just make sure the setup of the custom validators is done before the parsing of any schema to prevent registering the default validator (SpecificationValidator) * AVRO-3900: Improve the documentation Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVRO-3900
What is the purpose of the change
Verifying this change
Documentation