AVRO-2119: Run Apache Rat check on every java build #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gszadovszky
reviewed
Dec 14, 2017
| @@ -205,6 +205,11 @@ | |||
| </profile> | |||
| <profile> | |||
| <id>rat</id> | |||
| <activation> | |||
There was a problem hiding this comment.
I would suggest using <activeByDefault>true</activeByDefault> instead of depending on a not-existing property. I would be more obvious what's happening.
There was a problem hiding this comment.
Yes, you are right. This is simpler and cleaner.
nielsbasjes
force-pushed
the
AVRO-2119-Run-rat-always
branch
from
8c2d37c
to
94db620
Compare
gszadovszky
approved these changes
Dec 14, 2017
|
+1 |
nandorKollar
approved these changes
Dec 14, 2017
spacharya
approved these changes
Dec 14, 2017
|
I'm waiting to merge this until we have resolved the license header issue. |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply forces Apache Rat to run on every Java build.
Must be committed to branch-1.7 branch-1.8 and master.