AVRO-3884: Update local-timestamp example
#2735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The concept of the local-timestamp is each value is a recording of what can be seen on a calendar and a clock hanging on the wall, for example, "1969-07-20 16:17:39". It can be decomposed into year, month, day, hour, minute, and seconds fields, but with no time zone information available, it does not correspond to any specific point in time. It is often used in legacy systems. The example was 12 hours off.
tjwp
approved these changes
Feb 13, 2024
|
Thanks for the review @tjwp |
RanbirK
pushed a commit
to RanbirK/avro
that referenced
this pull request
May 13, 2024
The concept of the local-timestamp is each value is a recording of what can be seen on a calendar and a clock hanging on the wall, for example, "1969-07-20 16:17:39". It can be decomposed into year, month, day, hour, minute, and seconds fields, but with no time zone information available, it does not correspond to any specific point in time. It is often used in legacy systems. The example was 12 hours off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concept of the local-timestamp is each value is a recording of what can be seen on a calendar and a clock hanging on the wall, for example, "1969-07-20 16:17:39". It can be decomposed into year, month, day, hour, minute, and seconds fields, but with no time zone information available, it does not correspond to any specific point in time. It is often used in legacy systems.
The example was 12 hours off. Thanks @tjwp and @martin-g for raising this in https://github.com/apache/avro/pull/2554/files/3b9d95b046231132b77f8b7f90857f0f97f37916#r1437935439 馃憤
What is the purpose of the change
(For example: This pull request improves file read performance by buffering data, fixing AVRO-XXXX.)
Verifying this change
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation