Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3946: [Rust] Log warning/error for strange union types #2767

Merged
merged 1 commit into from Feb 26, 2024

Conversation

martin-g
Copy link
Member

AVRO-3946

A Union schema without any variants will log an ERROR from now on.
A Union schema with a single variant will log a WARN suggesting to drop the union.

What is the purpose of the change

  • Better feedback to the developer via logging

Verifying this change

  • New unit tests have been added

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@github-actions github-actions bot added the Rust label Feb 26, 2024
A Union schema without any variants will log an ERROR from now on.
A Union schema with a single variant will log a WARN suggesting to drop
the union.

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g martin-g force-pushed the avro-3946-log-warn-error-for-strange-unions branch from 57de9d7 to 903b5b8 Compare February 26, 2024 11:27
@martin-g martin-g merged commit db6cbe1 into main Feb 26, 2024
15 checks passed
@martin-g martin-g deleted the avro-3946-log-warn-error-for-strange-unions branch February 26, 2024 12:27
martin-g added a commit that referenced this pull request Feb 26, 2024
A Union schema without any variants will log an ERROR from now on.
A Union schema with a single variant will log a WARN suggesting to drop
the union.

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
(cherry picked from commit db6cbe1)
RanbirK pushed a commit to RanbirK/avro that referenced this pull request May 13, 2024
)

A Union schema without any variants will log an ERROR from now on.
A Union schema with a single variant will log a WARN suggesting to drop
the union.

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant