Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3978: Build with Java 11 minimum #2855

Merged
merged 1 commit into from Apr 29, 2024
Merged

Conversation

jbonofre
Copy link
Member

What is the purpose of the change

Upgrade Avro main to build with Java 11 minimum (and remove reference to Java 8).

Verifying this change

I verified the whole build worked on my machine.

Documentation

Avro wiki should be updated to mention Avro 1.12.x will be Java 11 minimum, and Avro 1.11.x is still Java 8 compliant.

@github-actions github-actions bot added Java Pull Requests for Java binding build website labels Apr 16, 2024
@jbonofre jbonofre changed the title AVRO-3978: Upgrade main to build with Java 11 minimum AVRO-3978: Build with Java 11 minimum Apr 16, 2024
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for working on this @jbonofre

I think it makes sense to set the minimum to JDK17 as suggested on the devlist: https://lists.apache.org/thread/6vbd3w5qk7mpb5lyrfyf2s0z1cymjt5w

Spark 4 will support JDK17 as a minimum and I see more project going into that direction since JDK11 has lost support September 2023.

@Fokko
Copy link
Contributor

Fokko commented Apr 16, 2024

Looks like the integration tests are still relying on JDK8:

[INFO] Required toolchain: jdk [ version='8' ]
Error:  No toolchain matched from 3 found for type jdk
Error:  Cannot find matching toolchain definitions for the following toolchain types:
jdk [ version='8' ]

Looks like:

@jbonofre
Copy link
Member Author

@Fokko yup, updating it :) Thanks !

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first step towards JDK17 :)

@jbonofre
Copy link
Member Author

@Fokko I will create another PR for JDK11 for avro 1.x branch and update this one for JDK17

@martin-g
Copy link
Member

AFAIR 1.11.x should stay with JDK 8

@jbonofre
Copy link
Member Author

@martin-g yes for 1.11 but what about 1.12 ? We keep JDK8 for 1.12 as well ?

@Fokko
Copy link
Contributor

Fokko commented Apr 29, 2024

My gist from the mail list:

  • 1.11.4 will be JDK8+
  • 1.12.0 will be JDK11+ (I suggested going to JDK17+ directly since security support has been dropped for JDK11 already, but didn't get a whole lot of replies :).

I'll go ahead and merge this since there is consensus on the ML

@Fokko Fokko merged commit 589b893 into apache:main Apr 29, 2024
8 checks passed
@jbonofre
Copy link
Member Author

👍

Thanks @Fokko !

@jbonofre jbonofre deleted the AVRO-3978 branch April 29, 2024 16:20
RanbirK pushed a commit to RanbirK/avro that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Java Pull Requests for Java binding website
Projects
None yet
3 participants