[AVRO-2228] Bump Apache Velocity to 2.0 #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
force-pushed
the
AVRO-2228
branch
2 times, most recently
from
63add06
to
641fb9c
Compare
| @@ -929,75 +919,6 @@ public static void main(String[] args) throws Exception { | |||
| compileProtocol(new File(args[0]), new File(args[1])); | |||
| } | |||
|
|
|||
| public static final class Slf4jLogChute implements LogChute { | |||
There was a problem hiding this comment.
Removing this class would break the API. Despite it is unlikely that any Avro client used this class (and very unfortunate that it is public, it seems that it isn't used anywhere else apart from this class), would it be possible to keep this, and mark as deprecated?
Fokko
force-pushed
the
AVRO-2228
branch
2 times, most recently
from
17ed126
to
668f761
Compare
- Remove Slf4jLogChute since 2.0 uses SLF4J itself - Update $velocityHasNext to $foreach.hasNext because of deprecation - Update $velocityCount to $foreach.count because of deprecation - 2.0 does not depend on apache-common collections anymore which used to be an old version with security issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slf4jLogChutesince 2.0 uses SLF4J itself: https://github.com/apache/velocity-engine#upgrading-from-velocity-17x-to-velocity-20