AVRO-2267 Removed copies of RandomData #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thiru-mg
commented
Nov 18, 2018
thiru-mg
commented
- Unified three near identical copies of RandomData.java into a single file.
- Main java code of tools module used to have a dependency on test code of avro module. It is not a good idea to have release code include test code. Broken the link, by placing the random data generation in avro module's util package.
Fokko
reviewed
Nov 18, 2018
| System.out.println("Usage: RandomData <schemafile> <outputfile> <count> [codec]"); | ||
| System.exit(-1); | ||
| } | ||
| Schema sch = Schema.parse(new File(args[0])); | ||
| Schema sch = new Schema.Parser().parse(new File(args[0])); |
There was a problem hiding this comment.
I think a static function is nicer here. What do you think?
There was a problem hiding this comment.
I think the static method is marked as deprecated (which is a wrapper around the non-static one), and the non-static version should be used instead.
There was a problem hiding this comment.
@nandorKollar Yes, you are right. The IDE complains about it and that is the reason I changed it.
Fokko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.