AVRO-1746 - Support JSON encoding in Ruby #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 17, 2015 10:34
| # -*- encoding: utf-8 -*- | ||
| # stub: avro 1.9.0.pre1 ruby lib | ||
|
|
||
| Gem::Specification.new do |s| |
There was a problem hiding this comment.
The gemspec is built using Echoe in the Rakefile. Could you merge your changes into there?
There was a problem hiding this comment.
I created it using rake build_gemspec. I've removed it for now.
added 2 commits
November 24, 2015 13:39
- Use 80 as line length
|
Hello, I've tried the code - it look real good - and i've had problems with the binary encoder |
|
@YuvalNaturalInt do you mean you have problems with the binary encoder in this branch? If yes, I would be happy to look into it if you could share more info about it. |
|
@yadavsaroj, this was closed as part of the process to move the project to git. I can't re-open it but you probably can. Seems like a good reminder to get this closed out! |
|
I would like this PR to be merged... |
SingingBush
pushed a commit
to SingingBush/avro
that referenced
this pull request
Jun 29, 2023
Also fix a bug where GenerateAvroProtocolTask can't be used without a runtime configuration
SingingBush
pushed a commit
to SingingBush/avro
that referenced
this pull request
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for JSON encoding in Ruby.
A note about implementation - in order to keep the patch minimum, I have made json encoder/decoder inherit from binary encoder/decoder. As part of future changes, may be we can define generic encoder/decoder base classes and have binary/json classes add specific implementations. After that's done, we might be able to DRY validation related logic.