Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-2468: Fix broken data interoperability on the Perl bindings #582

Merged
merged 2 commits into from Aug 20, 2019

Conversation

sekikn
Copy link
Contributor

@sekikn sekikn commented Jul 9, 2019

  • Fix Avro::Schema to take namespace into consideration
    when parsing named types in arrays/maps/unions.

  • Fix Avro::Schema to encode fixed type's size value
    into numeric when it outputs Avro schema.

  • To ensure the above fixes work, add data interop test
    for the Perl bindings.

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

I added the following tests:

  • xt/interop.t: test for ensuring data interoperability between other languages.
  • xt/schema.t: test for ensuring the revised parser can parse named types in arrays/maps/unions correctly. It tries to parse all schemas under the toplevel "share" directory, so it fails right now because of AVRO-2466. But once it's merged, this test is supposed to succeed.

I put these tests under the xt directory as "author tests", since they depends on the contents under the toplevel "share" directory, which are not included in the release distribution of the Perl bindings.

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

* Fix Avro::Schema to take namespace into consideration
  when parsing named types in arrays/maps/unions.

* Fix Avro::Schema to encode fixed type's size value
  into numeric when it outputs Avro schema.

* To ensure the above fixes work, add data interop test
  for the Perl bindings.
@sekikn
Copy link
Contributor Author

sekikn commented Jul 25, 2019

Resolved conflicts.

@Fokko Fokko merged commit 02dbe25 into apache:master Aug 20, 2019
RyanSkraba pushed a commit to RyanSkraba/avro that referenced this pull request Jan 27, 2020
…che#582)

* Fix Avro::Schema to take namespace into consideration
  when parsing named types in arrays/maps/unions.

* Fix Avro::Schema to encode fixed type's size value
  into numeric when it outputs Avro schema.

* To ensure the above fixes work, add data interop test
  for the Perl bindings.
RyanSkraba pushed a commit to RyanSkraba/avro that referenced this pull request Jan 27, 2020
…che#582)

* Fix Avro::Schema to take namespace into consideration
  when parsing named types in arrays/maps/unions.

* Fix Avro::Schema to encode fixed type's size value
  into numeric when it outputs Avro schema.

* To ensure the above fixes work, add data interop test
  for the Perl bindings.
RyanSkraba pushed a commit to RyanSkraba/avro that referenced this pull request Jan 28, 2020
…che#582)

* Fix Avro::Schema to take namespace into consideration
  when parsing named types in arrays/maps/unions.

* Fix Avro::Schema to encode fixed type's size value
  into numeric when it outputs Avro schema.

* To ensure the above fixes work, add data interop test
  for the Perl bindings.
RyanSkraba pushed a commit to RyanSkraba/avro that referenced this pull request Jan 29, 2020
…che#582)

* Fix Avro::Schema to take namespace into consideration
  when parsing named types in arrays/maps/unions.

* Fix Avro::Schema to encode fixed type's size value
  into numeric when it outputs Avro schema.

* To ensure the above fixes work, add data interop test
  for the Perl bindings.
iemejia pushed a commit that referenced this pull request Jan 31, 2020
* Fix Avro::Schema to take namespace into consideration
  when parsing named types in arrays/maps/unions.

* Fix Avro::Schema to encode fixed type's size value
  into numeric when it outputs Avro schema.

* To ensure the above fixes work, add data interop test
  for the Perl bindings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants