Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-2481: Introduce Perl::Critic for linting the Perl bindings #591

Merged
merged 2 commits into from Aug 29, 2019

Conversation

sekikn
Copy link
Contributor

@sekikn sekikn commented Jul 25, 2019

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

This PR adds linting feature to the Perl bindings. It also contains fixes for the existing violations.
I ran ./build.sh lint in the lang/perl directory and confirmed all violations were fixed.

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@Fokko
Copy link
Contributor

Fokko commented Jul 26, 2019

@sekikn The failed for an unknown reason. Can you rebase against lastest master?

@sekikn
Copy link
Contributor Author

sekikn commented Jul 27, 2019

Sure! Rebased on master.

@Fokko Fokko merged commit 516af09 into apache:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants