Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-2547: Add bzip2 support to the Perl bindings #640

Merged
merged 2 commits into from May 21, 2020

Conversation

sekikn
Copy link
Contributor

@sekikn sekikn commented Sep 4, 2019

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

I updated lang/perl/t/04_datafile.t to add a test for the bzip2 codec.

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@nandorKollar
Copy link
Contributor

Tests failed, because this depends on #638

@sekikn
Copy link
Contributor Author

sekikn commented Sep 7, 2019

Exactly, I'll rerun the CI once #638 is merged. Thanks for the comment!

@Fokko
Copy link
Contributor

Fokko commented Sep 10, 2019

@sekikn can you rebase? :-)

@sekikn
Copy link
Contributor Author

sekikn commented Sep 10, 2019

Sure, thanks for merging #638!

Copy link
Contributor

@nandorKollar nandorKollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkulp dkulp merged commit eb21a21 into apache:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants