AVRO-2577: Fix Bare Excepts #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kojiromike
force-pushed
the
AVRO-2577/fix-bare-except
branch
from
e979f1c
to
5c2442d
Compare
kojiromike
commented
Sep 30, 2019
lang/py/test/test_schema.py
Outdated
| @@ -408,15 +408,14 @@ def test_parse(self): | |||
| for example in EXAMPLES: | |||
| try: | |||
| schema.parse(example.schema_string) | |||
| except (schema.AvroException, schema.SchemaParseException): | |||
There was a problem hiding this comment.
@Fokko I could use some guidance here -- I believe this test is more correct than it was in the previous implementation, but it is now failing on a test case with schema
{"type": "long", "logicalType": "date"}
The implementation allows this to pass on line 921 where it falls back to the primitive type if the logical type doesn't match any earlier condition.
Should we raise an exception whenever a logicalType is specified if it doesn't match the expected primitive?
There was a problem hiding this comment.
Thanks, @nandorKollar. I've opened AVRO-2580 for this and will address that issue first to avoid mixing contexts in this PR.
There was a problem hiding this comment.
Sounds good to me, thanks!
There was a problem hiding this comment.
That change is in #668. Please take a look if you get the chance.
kojiromike
force-pushed
the
AVRO-2577/fix-bare-except
branch
from
f2501fb
to
de97081
Compare
kojiromike
force-pushed
the
AVRO-2577/fix-bare-except
branch
from
de97081
to
dda3a33
Compare
RyanSkraba
pushed a commit
to RyanSkraba/avro
that referenced
this pull request
Jan 20, 2020
* AVRO-2577: Fix Bare Excepts * AVRO-2577: Don't Count Failure as Success
RyanSkraba
pushed a commit
to RyanSkraba/avro
that referenced
this pull request
Jan 20, 2020
* AVRO-2577: Fix Bare Excepts * AVRO-2577: Don't Count Failure as Success
RyanSkraba
pushed a commit
to RyanSkraba/avro
that referenced
this pull request
Jan 21, 2020
* AVRO-2577: Fix Bare Excepts * AVRO-2577: Don't Count Failure as Success
RyanSkraba
pushed a commit
to RyanSkraba/avro
that referenced
this pull request
Jan 21, 2020
* AVRO-2577: Fix Bare Excepts * AVRO-2577: Don't Count Failure as Success
RyanSkraba
pushed a commit
to RyanSkraba/avro
that referenced
this pull request
Jan 22, 2020
* AVRO-2577: Fix Bare Excepts * AVRO-2577: Don't Count Failure as Success
RyanSkraba
added a commit
to kojiromike/avro
that referenced
this pull request
Jan 22, 2020
RyanSkraba
pushed a commit
to kojiromike/avro
that referenced
this pull request
Jan 27, 2020
* AVRO-2577: Fix Bare Excepts * AVRO-2577: Don't Count Failure as Success
RyanSkraba
added a commit
to kojiromike/avro
that referenced
this pull request
Jan 27, 2020
RyanSkraba
pushed a commit
to RyanSkraba/avro
that referenced
this pull request
Jan 27, 2020
* AVRO-2577: Fix Bare Excepts * AVRO-2577: Don't Count Failure as Success
RyanSkraba
pushed a commit
that referenced
this pull request
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
Tests
Commits
Documentation