AVRO-1808. Added possibility of overriding lock mechanics for Requestor.handshakeLock #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KonstantinUsachev Do you know if this is still relevant? |
@Fokko Hi. In our case it was necessary, because we used Avro with Quasar framework where it is forbidden to use ReentrantLock (it blocks thread instead of fiber). Don't know, what is the current situation, because we finished our work with that project. So I don't need it anymore personally and, actually, don't quite like this PR now :) because in this case we have unused handshakeLock field. But I will not give any better, so feel free to reject it. |
|
@KonstantinUsachev Thanks for the elaborate answer. Let's close this for now then. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look at https://issues.apache.org/jira/browse/AVRO-1808 for more information