Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-2754: Add support for UUID logical types in C# #822

Merged
merged 4 commits into from Feb 24, 2020
Merged

AVRO-2754: Add support for UUID logical types in C# #822

merged 4 commits into from Feb 24, 2020

Conversation

mkellogg
Copy link
Contributor

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
  • Modified codegen test to add logical type tests. Nullable value types were also broken in the test so that fix sneaked in
  • LogicalTypeTests.TestUuid - Verifies translation between serialized string and System.Guid

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@Fokko
Copy link
Contributor

Fokko commented Feb 20, 2020

Thanks for the contribution @mkellogg. Could you add the license?

[WARNING] Files with unapproved licenses:
  lang/csharp/src/apache/main/Util/Uuid.cs

@mkellogg
Copy link
Contributor Author

Sorry about that. Added.

Copy link
Member

@blachniet blachniet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I had one change request. Thank you @mkellogg!

lang/csharp/src/apache/main/CodeGen/CodeGen.cs Outdated Show resolved Hide resolved
Fully qualified Nullable type

Co-Authored-By: Brian Lachniet <blachniet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants