Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVRO-2174: Python EnumSchema Symbol Validation #830

Merged
merged 3 commits into from Feb 23, 2020
Merged

AVRO-2174: Python EnumSchema Symbol Validation #830

merged 3 commits into from Feb 23, 2020

Conversation

kojiromike
Copy link
Contributor

Jira

  • Addresses AVRO-2174
  • References it in the PR title
  • Adds no dependencies

Tests

  • Adds tests for:
    • schema.parse raises an InvalidName when an enum schema symbol has a
      space in it.
    • optionally disabling this behavior for compatibility.

Commits

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.

@kojiromike kojiromike self-assigned this Feb 22, 2020
Fokko
Fokko approved these changes Feb 23, 2020
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kojiromike

@kojiromike kojiromike merged commit 8288df8 into apache:master Feb 23, 2020
@kojiromike kojiromike deleted the AVRO-2174/py-enum-symbol-spaces branch February 23, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Fokko approved these changes

Assignees

@kojiromike kojiromike

Labels
Python
Projects
None yet
Milestone
No milestone
2 participants
@kojiromike @Fokko