AVRO-1884: Add set source file suffix function for generate non-java file #90
Conversation
|
Hi @shijinkui, thanks for opening this. I'm not sure how this is intended to work. We currently use the "java" suffix because all of the files that are generated are Java code. Since we don't generate scala, I don't see how this is very useful. If you wanted to add Scala code generation, that would be useful, but I think in that case we'd want to hard-code "scala" as the file suffix. |
|
@rdblue thanks for review. When i want't generate scala code, I use my own velocity template instead of default velocity template. So the default suffix Java is not suitable. Make Thanks. |
|
Hi! Please file an issue on the project's JIRA tracker, link to this PR, and set the status to "Patch Available". For more details on contributing to Avro, please see our contribution guide |
shijinkui
changed the title
…for example:
```
compiler.setSuffix(".scala")
compiler.setTemplateDir(templatePath)
compiler.compileToDestination(file, new File("src/main/scala/"))
```
shijinkui
force-pushed
the
compiler_set_file_suffix
branch
from
91f3ec1
to
9c2ea4d
Compare
|
Thanks for the response, @shijinkui. That makes more sense. +1 |
Use when generating non-Java files with custom templates. For example:
```
compiler.setSuffix(".scala")
compiler.setTemplateDir(scalaTemplatePath)
compiler.compileToDestination(file, new File("src/main/scala/"))
```
Closes #90.
…-support Add support for generating getters that return Optional
example: