New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVRO-2875: Add logging to avro-tools #925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good: the LICENSE for the avro-tools jar already has a section for slf4j due to our use of slf4j-api and it is generic enough to also cover slf4j-simple.
needs to change: avro-tools embeds a log4j.properties
file that defines the logging output. we should remove that file since we're not going to use log4j with this update. if we can make the format match that would be ideal. if it doesn't then we need to release note the difference.
occurred to me: do we need one of the other slf4j bridge jars in order to e.g. get the logging from the hadoop libraries we are including in the tools jar? |
@busbey Good point! It looks like both points can be resolved by restoring the With this change both avro-tools-1.9.2.jar and avro-tools-1.11.0-SNAPSHOT.jar will produce the following Hadoop warning:
(Missing in 1.10.0) |
@busbey Hello! Can you PTAL? This should restore the pre-1.10.0 behaviour for logging in avro-tools. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am merging this because it makes sense and fixes the 'logging regression', in any case don't hesitate to tell if you prefer this done other way @busbey and we will fix it. |
* AVRO-2875: Add logging to avro-tools * Use slf4j-log4j12 instead of slf4j-simple
Cherry-picked to branch-1.10. |
* AVRO-2875: Add logging to avro-tools * Use slf4j-log4j12 instead of slf4j-simple
Make sure you have checked all steps below.
Jira
Tests
Commits
Documentation