[BEAM-1622] Reword RunnableOnService to ValidatesRunner #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): Jenkins built the site at commit id 81bafde with Jekyll and staged it here. Happy reviewing. Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again. |
robertwb
pushed a commit
to robertwb/incubator-beam
that referenced
this pull request
Jun 5, 2018
robertwb
pushed a commit
to robertwb/incubator-beam
that referenced
this pull request
Jun 5, 2018
melap
pushed a commit
to apache/beam
that referenced
this pull request
Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is merged to master of the SDK now.
It looks to me like a simple grep leaves some confusing wording - mostly wording that would already be potentially troublesome, since the actual meaning of this annotation hasn't changed. LMK what you think about whether to move forwards and improve later versus try to reword here.
R: @davorbonaci