Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes Splittable DoFn in the capability matrix #259

Closed
wants to merge 1 commit into from

Conversation

jkff
Copy link

@jkff jkff commented Jun 23, 2017

@asfgit
Copy link

asfgit commented Jun 23, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/531/

Jenkins built the site at commit id adf7f2b with Jekyll and staged it here. Happy reviewing.

Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again.

@jkff
Copy link
Author

jkff commented Jun 23, 2017

retest this please

@asfgit
Copy link

asfgit commented Jun 23, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/532/

Jenkins built the site at commit id adf7f2b with Jekyll and staged it here. Happy reviewing.

Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again.

@jkff
Copy link
Author

jkff commented Jun 23, 2017

The test failure looks pre-existing.

@kennknowles
Copy link
Member

I agree it is not related. Curiously, that link is not dead via the live site. It is the Maturity Model's "550 JIRA resolved during incubation" link, if I haven't made a mistake.

@kennknowles
Copy link
Member

kennknowles commented Jun 26, 2017

It seems like it might be nice to give a ~2 sentence summary of the support when details are expanded. For example, the sorts of splitting that we do. It is redundant with other documentation we'll need to provide, but adds to the ubiquity of documentation that leads to users just knowing what to do I think.

@jkff
Copy link
Author

jkff commented Jun 27, 2017

Added some more information, also to the Source API.

@asfgit
Copy link

asfgit commented Jun 27, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/540/

Jenkins built the site at commit id d9eeb79 with Jekyll and staged it here. Happy reviewing.

Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again.

@jkff
Copy link
Author

jkff commented Jun 28, 2017

Ping.

@tgroh tgroh requested a review from kennknowles June 29, 2017 21:17
@jkff
Copy link
Author

jkff commented Jul 11, 2017

retest this please

@asfgit
Copy link

asfgit commented Jul 11, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/559/

Jenkins built the site at commit id d9eeb79 with Jekyll and staged it here. Happy reviewing.

Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again.

values:
- class: model
l1: 'Partially'
l2: DoFn with non-monolithic element processing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reverse the polarity here and describe non-monolothic instead? Something like "splitting and checkpointing of processing within an element"? My phrasing is not great, but something...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

- class: model
l1: 'Partially'
l2: DoFn with non-monolithic element processing
l3: Allows users to develop DoFn's that process a single element in portions ("restrictions"), executed in parallel or sequentially, making it possible to use DoFn for developing bounded and unbounded data sources much more flexible and composable with the rest of the Beam model than the Source API. See http://s.apache.org/splittable-do-fn. Design is in progress on achieving parity with Source API regarding progress signals.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think keeping it more descriptive and pithy rather than just relating to the Source API. Maybe

Allows users to develop DoFn's that process a single element in portions ("restrictions"), executed in parallel or sequentially. This supersedes the unbounded and bounded `Source` APIs by supporting all of their features on a per-element basis. See http://s.apache.org/splittable-do-fn. Design is in progress on achieving parity with Source API regarding progress signals.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jkff
Copy link
Author

jkff commented Jul 18, 2017

Thanks, PTAL.

@kennknowles
Copy link
Member

@asfbot merge

@asfgit
Copy link

asfgit commented Jul 18, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/571/

Jenkins built the site at commit id 3cc42f8 with Jekyll and staged it here. Happy reviewing.

Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again.

@kennknowles
Copy link
Member

@asfgit merge

@asfgit asfgit closed this in 992a3fc Jul 18, 2017
@jkff jkff deleted the cap-sdf branch July 18, 2017 01:19
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
melap pushed a commit to apache/beam that referenced this pull request Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants