-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-2335] Document how to run NeedsRunner tests #284
[BEAM-2335] Document how to run NeedsRunner tests #284
Conversation
R: @jasonkuster |
retest this please |
Refer to this link for build results (access rights to CI server needed): Jenkins built the site at commit id 620f301 with Jekyll and staged it here. Happy reviewing. Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again. |
R: @melap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR! Just a couple minor wording comments... I will leave verification of the actual commands to @jasonkuster
src/contribute/testing.md
Outdated
@@ -302,6 +302,37 @@ importance of testing, Beam has a robust set of unit tests, as well as testing | |||
coverage measurement tools, which protect the codebase from simple to moderate | |||
breakages. Beam Java unit tests are written in JUnit. | |||
|
|||
#### How to run NeedsRunner tests | |||
|
|||
NeedsRunner is a category of tests that require a Beam runner. Subset of these |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A subset of these ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
src/contribute/testing.md
Outdated
$ mvn -pl runners/direct-java surefire:test@validates-runner-tests -Dtest=MapElementsTest#testMapBasic | ||
``` | ||
|
||
will run single `MapElementsTest.testMapBasic()` test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... will run the MapElementsTest.testMapBasic()
test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Refer to this link for build results (access rights to CI server needed): Jenkins built the site at commit id f9c2bc0 with Jekyll and staged it here. Happy reviewing. Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again. |
@jasonkuster PTAL |
Apologies -- this somehow didn't show up in my list of notifications. LGTM -- thanks for the contribution! |
@kennknowles for merge |
@asfgit merge |
Answer the first question from BEAM-2335: "how do I execute only one test marked as @NeedsRunner?".