Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-2335] Document how to run NeedsRunner tests #284

Conversation

alex-filatov
Copy link

Answer the first question from BEAM-2335: "how do I execute only one test marked as @NeedsRunner?".

@reuvenlax
Copy link

R: @jasonkuster

@alex-filatov
Copy link
Author

retest this please

@asfgit
Copy link

asfgit commented Aug 15, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/624/

Jenkins built the site at commit id 620f301 with Jekyll and staged it here. Happy reviewing.

Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again.

@kennknowles
Copy link
Member

R: @melap

Copy link

@melap melap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! Just a couple minor wording comments... I will leave verification of the actual commands to @jasonkuster

@@ -302,6 +302,37 @@ importance of testing, Beam has a robust set of unit tests, as well as testing
coverage measurement tools, which protect the codebase from simple to moderate
breakages. Beam Java unit tests are written in JUnit.

#### How to run NeedsRunner tests

NeedsRunner is a category of tests that require a Beam runner. Subset of these
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A subset of these ...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

$ mvn -pl runners/direct-java surefire:test@validates-runner-tests -Dtest=MapElementsTest#testMapBasic
```

will run single `MapElementsTest.testMapBasic()` test.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... will run the MapElementsTest.testMapBasic() test.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@asfgit
Copy link

asfgit commented Sep 12, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/694/

Jenkins built the site at commit id f9c2bc0 with Jekyll and staged it here. Happy reviewing.

Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again.

@alex-filatov
Copy link
Author

@jasonkuster PTAL

@jasonkuster
Copy link

Apologies -- this somehow didn't show up in my list of notifications. LGTM -- thanks for the contribution!

@melap
Copy link

melap commented Sep 29, 2017

@kennknowles for merge

@kennknowles
Copy link
Member

@asfgit merge

@asfgit asfgit closed this in 574ba81 Sep 29, 2017
@alex-filatov alex-filatov deleted the beam-2335-document-mvn-commands-1 branch October 19, 2017 15:27
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
melap pushed a commit to apache/beam that referenced this pull request Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants