Adds guidance on how to test transform configuration/validation #301
Conversation
|
Refer to this link for build results (access rights to CI server needed): Jenkins built the site at commit id 5eed3c8 with Jekyll and staged it here. Happy reviewing. Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again. |
|
R: @melap (feel free to decline, just sending things your way if I think they might be in your wheelhouse) |
| The code for constructing and validating a transform is usually trivial and mostly boilerplate. However, minor mistakes or typos in it can have serious consequences (e.g. ignoring a property that the user has set), so it needs to be tested as well. Yet, an excessive amount of trivial tests can be hard to maintain and give a false impression that the transform is well-tested. | ||
|
|
||
| Do: | ||
| * Test non-trivial validation code: where missing/incorrect/uninformative validation may lead to serious problems: data loss, counter-intuitive behavior, value of a property being silently ignored, or other hard-to-debug errors. Create 1 test per non-trivial class of validation error. Some examples of validation that should be tested: |
There was a problem hiding this comment.
nit - the : after validation code: seems extraneous
|
Thomas is OOO so, say, R: @robertwb |
|
LGTM, thanks. |
jkff
force-pushed
the
validation-testing
branch
from
5eed3c8
to
09ea01e
Compare
|
@asfgit merge |
|
Refer to this link for build results (access rights to CI server needed): Jenkins built the site at commit id 09ea01e with Jekyll and staged it here. Happy reviewing. Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again. |
R: @tgroh