NonNull by default in runners/core/metrics

apache · Nov 8, 2017 · 34a46b1 · 34a46b1
1 parent a87b02a
commit 34a46b1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/...core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsContainerStepMap.java b/...core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsContainerStepMap.java
@@ -25,6 +25,7 @@
 import java.util.HashMap;
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
+import javax.annotation.Nullable;
 import org.apache.beam.runners.core.construction.metrics.MetricFiltering;
 import org.apache.beam.runners.core.construction.metrics.MetricKey;
 import org.apache.beam.runners.core.metrics.MetricUpdates.MetricUpdate;
@@ -425,14 +426,14 @@ private static class AccumulatedMetricResult<T> implements MetricResult<T> {
       private final MetricName name;
       private final String step;
       private final T attempted;
-      private final T committed;
+      private final @Nullable T committed;
       private final boolean isCommittedSupported;
 
       private AccumulatedMetricResult(
           MetricName name,
           String step,
           T attempted,
-          T committed,
+          @Nullable T committed,
           boolean isCommittedSupported) {
         this.name = name;
         this.step = step;

diff --git a/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/package-info.java b/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/package-info.java
@@ -19,4 +19,8 @@
 /**
  * Utilities for runners to implement metrics.
  */
+@DefaultAnnotation(NonNull.class)
 package org.apache.beam.runners.core.metrics;
+
+import edu.umd.cs.findbugs.annotations.DefaultAnnotation;
+import edu.umd.cs.findbugs.annotations.NonNull;