Merge pull request #8992 from ibzib/subprocess

[BEAM-7670] portable py: prevent race opening worker subprocess
apache · Aug 19, 2019 · 7906149 · 7906149
2 parents eddaf92 + c7ace41
commit 7906149
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/sdks/python/apache_beam/runners/portability/portable_runner.py b/sdks/python/apache_beam/runners/portability/portable_runner.py
@@ -496,7 +496,10 @@ def NotifyRunnerAvailable(self, start_worker_request, context):
                        self._worker_threads,
                        start_worker_request.worker_id)]
         logging.warn("Starting worker with command %s" % (command))
-        worker_process = subprocess.Popen(command, stdout=subprocess.PIPE)
+        worker_process = subprocess.Popen(
+            command,
+            stdout=subprocess.PIPE,
+            close_fds=True)
 
         # Register to kill the subprocess on exit.
         atexit.register(worker_process.kill)