Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-7670] portable py: prevent race opening worker subprocess #8992

Merged
merged 1 commit into from Aug 19, 2019
Merged

[BEAM-7670] portable py: prevent race opening worker subprocess #8992

merged 1 commit into from Aug 19, 2019

Conversation

ibzib
Copy link
Contributor

@ibzib ibzib commented Jul 3, 2019

SDK workers weren't being started properly in subprocess mode because of a known multithreading issue in python 2: dropbox/pyannotate#67

R: @angoenka

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status		 Build Status Build Status Build Status
Build Status
Python Build Status
Build Status		 --- Build Status
Build Status		 Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@angoenka
Copy link
Contributor

angoenka commented Jul 3, 2019

LGTM

Lets wait for the tests to pass

@angoenka
Copy link
Contributor

angoenka commented Jul 3, 2019

Run Portable_Python PreCommit

@angoenka
Copy link
Contributor

angoenka commented Jul 3, 2019

Run Python PreCommit

@ibzib
Copy link
Contributor Author

ibzib commented Jul 8, 2019

Run Portable_Python PreCommit

3 similar comments
@ibzib
Copy link
Contributor Author

ibzib commented Jul 10, 2019

Run Portable_Python PreCommit

@ibzib
Copy link
Contributor Author

ibzib commented Jul 10, 2019

Run Portable_Python PreCommit

@ibzib
Copy link
Contributor Author

ibzib commented Jul 16, 2019

Run Portable_Python PreCommit

@ibzib
Copy link
Contributor Author

ibzib commented Jul 16, 2019

Run Python PreCommit

@ibzib
Copy link
Contributor Author

ibzib commented Jul 17, 2019

@angoenka let's merge this. The 2 failures in Python precommit are both known flakes

@ibzib
Copy link
Contributor Author

ibzib commented Jul 31, 2019

ping @angoenka

@tvalentyn
Copy link
Contributor

Gentle reminder @angoenka .

angoenka
angoenka approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@angoenka angoenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM

@angoenka
Copy link
Contributor

Run Python PreCommit

@ibzib ibzib merged commit 7906149 into apache:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angoenka angoenka angoenka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ibzib @angoenka @tvalentyn