Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8593] Remove testSelectFromTableWithMap from ZetaSQLDialectSpecTest #10020

Closed
wants to merge 1 commit into from

Conversation

robinyqiu
Copy link
Contributor

Although table with a map field is supported by SchemaBaseBeamTable, ZetaSQL does not have a map type.

r: @apilloud
cc: @kennknowles @amaliujia

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@amaliujia
Copy link
Contributor

This test is still useful as it is testing what will happen when reading from a table that has unsupported type (aka. MAP). Current expected result is the map column will be skipped.

@kennknowles
Copy link
Member

Interesting point. It may add convenience to Beam SQL to be able to process rows that include unsupported types. Because Beam schemas are not limited to a particular SQL dialect this will apply for SqlTransform for sure. I'm not sure what the right answer is. This is a good question for the dev@ list. Options seem to be (1) error (2) error only if the user tries to "touch" the column otherwise it doesn't matter. The test should be named and commented to be about this, not about map.

@robinyqiu
Copy link
Contributor Author

Created JIRA to track this: https://issues.apache.org/jira/browse/BEAM-8593

The test should be named and commented to be about this, not about map.

Agree.

@robinyqiu robinyqiu changed the title Remove testSelectFromTableWithMap from ZetaSQLDialectSpecTest [BEAM-8593] Remove testSelectFromTableWithMap from ZetaSQLDialectSpecTest Nov 8, 2019
@stale
Copy link

stale bot commented Jan 7, 2020

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Jan 7, 2020
@stale
Copy link

stale bot commented Jan 14, 2020

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants