New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-8575] Test DoFn context params #10130
Conversation
R: @Chamikara Hi Cham, this is one of the adding missing tests PRs. This PR has two simple tests for DnFn context params. PTAL:) Thanks! |
Run Python Dataflow ValidatesRunner |
Retest this please |
Run Python Dataflow ValidatesRunner |
LGTM. Thanks. Will merge after tests pass. |
Thanks for the prompt review, Cham! |
Run Python Dataflow ValidatesRunner |
Hi Cham, I found the validates runner tests are failing due to that some tests should not be run as validates runner tests. They were tagged with validates runner in recent. I have a PR to revert those #10262. PTAL, Thanks! @chamikaramj I will revert some tags in this PR too. |
Retest this please |
Run Dataflow Python ValidatesRunner |
Run Python Dataflow ValidatesRunner |
Validates runner test failed due to test_flatten_no_pcollection. This test raises an exception in the test, and therefore should not be a validates runner test. #10286 to remove it from the validates runner tests. |
Run Python Dataflow ValidatesRunner |
Run Python Spark ValidatesRunner |
Run Python 3.5 Flink ValidatesRunner |
Hi @chamikaramj, I don't think the current failure has something to do with the new tests. Do we need to wait till they both pass? |
Yeah, seems to be unrelated. Merging. |
* [BEAM-8575] Test DoFn context params * fixup
Add two tests to test DoFn.ElementParam and DoFn.KeyParam.
Tag the other DoFn param tests as validates runner test to allow them to be picked up to run against Dataflow service.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.