Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8575] Test DoFn context params #10130

Merged
merged 2 commits into from Dec 10, 2019
Merged

Conversation

liumomo315
Copy link
Contributor

Add two tests to test DoFn.ElementParam and DoFn.KeyParam.

Tag the other DoFn param tests as validates runner test to allow them to be picked up to run against Dataflow service.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@liumomo315
Copy link
Contributor Author

R: @Chamikara

Hi Cham, this is one of the adding missing tests PRs. This PR has two simple tests for DnFn context params. PTAL:) Thanks!

@liumomo315
Copy link
Contributor Author

Run Python Dataflow ValidatesRunner

@chamikaramj
Copy link
Contributor

Retest this please

@chamikaramj
Copy link
Contributor

Run Python Dataflow ValidatesRunner

@chamikaramj
Copy link
Contributor

LGTM. Thanks.

Will merge after tests pass.

@liumomo315
Copy link
Contributor Author

Thanks for the prompt review, Cham!

@liumomo315
Copy link
Contributor Author

Run Python Dataflow ValidatesRunner

@liumomo315
Copy link
Contributor Author

Hi Cham, I found the validates runner tests are failing due to that some tests should not be run as validates runner tests. They were tagged with validates runner in recent. I have a PR to revert those #10262. PTAL, Thanks! @chamikaramj

I will revert some tags in this PR too.

@chamikaramj
Copy link
Contributor

Retest this please

@liumomo315
Copy link
Contributor Author

Run Dataflow Python ValidatesRunner

@liumomo315
Copy link
Contributor Author

Run Python Dataflow ValidatesRunner

@liumomo315
Copy link
Contributor Author

Validates runner test failed due to test_flatten_no_pcollection. This test raises an exception in the test, and therefore should not be a validates runner test. #10286 to remove it from the validates runner tests.

@liumomo315
Copy link
Contributor Author

Run Python Dataflow ValidatesRunner

@liumomo315
Copy link
Contributor Author

Run Python Spark ValidatesRunner

@liumomo315
Copy link
Contributor Author

Run Python 3.5 Flink ValidatesRunner

@liumomo315
Copy link
Contributor Author

Hi @chamikaramj, I don't think the current failure has something to do with the new tests. Do we need to wait till they both pass?

@chamikaramj
Copy link
Contributor

Yeah, seems to be unrelated. Merging.

@chamikaramj chamikaramj merged commit bdd70ab into apache:master Dec 10, 2019
dpcollins-google pushed a commit to dpcollins-google/beam that referenced this pull request Dec 20, 2019
* [BEAM-8575] Test DoFn context params

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants