Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8575] Revert validates runner test tag to some tests. They caus… #10262

Merged

Conversation

liumomo315
Copy link
Contributor

…ed post-commit failure. For example, https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_PR/166/consoleFull


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@liumomo315
Copy link
Contributor Author

@chamikaramj This PR is to revert the validates runner tags for some tests as mentioned in #10130. Thanks!

@chamikaramj
Copy link
Contributor

Any idea why tests failed ?

@liumomo315
Copy link
Contributor Author

The do_fn tests failure should have something to do with Dataflow runner splitting task into more than one bundle. WAI.

The window tests just timed out on Dataflow runner, I don't know the reason.

@chamikaramj
Copy link
Contributor

Looks like lint error is related.

************* Module apache_beam.transforms.window_test  
  apache_beam/transforms/window_test.py:25:0: W0611: Unused attr imported from nose.plugins.attrib (unused-import)

https://scans.gradle.com/s/wjoakhbhkkl3a/console-log?task=:sdks:python:test-suites:tox:py37:lintPy37

@liumomo315
Copy link
Contributor Author

Fixed the unused import:) Thanks, Cham!

@chamikaramj
Copy link
Contributor

LGTM. Thanks.

@chamikaramj chamikaramj merged commit 2ee01c7 into apache:master Dec 3, 2019
@tvalentyn
Copy link
Contributor

tvalentyn commented Dec 3, 2019

I believe sdks/python/apache_beam/transforms/window_test.py will pass once #10265 is merged, new tests actually caught a bug. however tests in ptransform_tests are failing from the moment we marked them to be VR test.
We should have run the VR suite on the test before merging #10145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants