Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8470] Exclude failed ValidatesRunner tests #10221

Merged

Conversation

aromanenko-dev
Copy link
Contributor

@aromanenko-dev aromanenko-dev commented Nov 26, 2019

Exclude failed ValidatesRunner tests to prevent SparkStructuredStreaming Runner ValidatesRunner Tests job being always red.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@aromanenko-dev
Copy link
Contributor Author

Run Spark StructuredStreaming ValidatesRunner

@aromanenko-dev aromanenko-dev requested review from iemejia and echauchot and removed request for iemejia November 26, 2019 15:36
@aromanenko-dev
Copy link
Contributor Author

@echauchot please, take a look

Copy link
Contributor

@echauchot echauchot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, I would prefer to keep it red until they all pass because it is the essence of the tests. As they are not UTests, they don't break the build.

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Nov 26, 2019

If they are always red, it's difficult to say if we have a regression or not with every new PR coming. You need to compare test results all the time, it's not convenient (this is what I already did several times).

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Nov 26, 2019

IMHO, I would prefer to keep it red until they all pass because it is the essence of the tests.

We have disabled a bunch of other tests (that are failing) as well. Do we need to enable them in this case?

@echauchot
Copy link
Contributor

echauchot commented Nov 26, 2019

We have disabled a bunch of other tests (that are failing) as well. Do we need to enable them in this case?

well, you have a point.

If they are always red, it's difficult to say if we have a regression or not with every new PR coming. You need to compare test results all the time, it's not convenient (this is what I already did several times).

you're right here also.

What is the correct way to avoid forgetting fixing the non-passing tests ? Any suggestion better than listing content of build.gradle exclusions ?

@aromanenko-dev
Copy link
Contributor Author

@echauchot I'd prefer to keep ValidatesRunner Tests green and create a Jira(s) about failing tests since, in the end, there are the issues with transforms implementation (even if it's just corner cases). Wdyt?

Copy link
Contributor

@echauchot echauchot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.
please create the jiras.
LGTM, merging

@echauchot echauchot merged commit 3e7865e into apache:master Nov 27, 2019
@aromanenko-dev
Copy link
Contributor Author

For the reference: https://issues.apache.org/jira/browse/BEAM-8839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants