-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-8470] Exclude failed ValidatesRunner tests #10221
[BEAM-8470] Exclude failed ValidatesRunner tests #10221
Conversation
Run Spark StructuredStreaming ValidatesRunner |
@echauchot please, take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, I would prefer to keep it red until they all pass because it is the essence of the tests. As they are not UTests, they don't break the build.
If they are always red, it's difficult to say if we have a regression or not with every new PR coming. You need to compare test results all the time, it's not convenient (this is what I already did several times). |
We have disabled a bunch of other tests (that are failing) as well. Do we need to enable them in this case? |
well, you have a point.
you're right here also. What is the correct way to avoid forgetting fixing the non-passing tests ? Any suggestion better than listing content of build.gradle exclusions ? |
@echauchot I'd prefer to keep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.
please create the jiras.
LGTM, merging
For the reference: https://issues.apache.org/jira/browse/BEAM-8839 |
Exclude failed ValidatesRunner tests to prevent
SparkStructuredStreaming Runner ValidatesRunner Tests
job being always red.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.