[BEAM-8932] [BEAM-9036] Revert reverted commit to use PubsubMessage as the canonical type in beam client #10474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age throughout."" This reverts commit aeae2f4.
|
+R: @boyuanzz |
boyuanzz
changed the title
|
Run SQL PostCommit |
|
Run Java PostCommit |
dpcollins-google
force-pushed
the
master
branch
2 times, most recently
from
e6e73b1
to
e0e4ec0
Compare
|
Run Java PreCommit |
|
Run SQL PostCommit |
|
Run Java PostCommit |
dpcollins-google
force-pushed
the
master
branch
from
e0e4ec0
to
788611a
Compare
|
Run Java PreCommit |
|
Run SQL PostCommit |
|
Run Java PostCommit |
|
Run Python PreCommit |
dpcollins-google
force-pushed
the
master
branch
from
788611a
to
9304d1c
Compare
|
Run PreCommit |
|
Run Java PreCommit |
|
Retest all please |
|
Run Java PreCommit |
|
I don't think the test failures in Java prevommit are related to current changes. Let's try it again. |
|
Run Java PreCommit |
2 similar comments
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Run SQL PostCommit |
kennknowles
reviewed
Jan 8, 2020
| if (pubsubMessage.getAttributes() != null) { | ||
| attributes = pubsubMessage.getAttributes(); | ||
| } else { | ||
| attributes = new HashMap<>(); |
There was a problem hiding this comment.
This would be more efficient and clear as Collections.emptyMap() which is immutable and does not involve allocation.
boyuanzz
added a commit
that referenced
this pull request
Jan 10, 2020
vmarquez
pushed a commit
to vmarquez/beam
that referenced
this pull request
Apr 1, 2020
…s the canonical type in beam client (apache#10474) * Revert "Revert "[BEAM-8932] Modify PubsubClient to use the proto message throughout."" This reverts commit aeae2f4. * Check for null attribute map in IncomingMessage before adding on PubsubMessage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is safe now that a null check was added on the attribute map in the json client.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.