[BEAM-9405] Fix post-commit error about create_job_service #11001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create_job_service was renamed since it now returns a new type, JobServiceHandle. revert to use the original name so that it does not break in scenarios like the test which do not care about the return type.
|
R: @kamilwu |
|
run python 2 postcommit |
|
@udim tests pass. btw, I don't have the ability to merge this. should I? |
Perhaps you need to also be a member of https://github.com/orgs/apache/teams/beam-committers, but I don't know if you should be doing anything. @kennknowles |
|
Thanks for taking care of that, @chadrik! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PortableRunner.create_job_servicewas renamed since it now returns a new type,JobServiceHandle. This PR changes that method back to its original name, so that it does not break in scenarios like the test which do not care about the return type. It also adds a docstring and improves some variable names to add additional clarity.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.