[BEAM-8335] Display rather than logging when is_in_notebook. #11032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added an IPythonLogHandler to display logs as styled HTMLs to frontends connected to current IPython kernel. The implementation works with all IPython notebooks. 2. The user can control the logging with native Python logging APIs. 3. The log hanlder is only registered when current environment is in a notebook and it only affects module loggers under interactive package. Change-Id: Iaec9272e0ee61d091979822680615791f1a57cd6
|
R: @rohdesamuel PTAL |
|
R: @pabloem Thanks! |
|
retest this please |
Change-Id: Iaab96e178f1ee286cb064d88563459503e60ec9d
|
retest this please |
1 similar comment
|
retest this please |
Change-Id: I29aa356a5310de42f43d6610081f2378ea16db9d
|
retest this please |
1 similar comment
|
retest this please |
|
Run Python PreCommit |
|
Run PythonFormatter PreCommit |
|
Run Portable_Python PreCommit |
1 similar comment
|
Run Portable_Python PreCommit |
|
Run PythonFormatter PreCommit |
|
thanks Ning! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frontends connected to current IPython kernel. The implementation
works with all IPython notebooks.
notebook and it only affects module loggers under interactive
package.
doesn't change any real logger's default configuration.
Change-Id: Iaec9272e0ee61d091979822680615791f1a57cd6
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.