-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-9443] support direct_num_workers=0 #11372
Conversation
CHANGES.md
Outdated
@@ -67,6 +67,7 @@ | |||
[Ensuring Python Type Safety](https://beam.apache.org/documentation/sdks/python-type-safety/) | |||
and an upcoming | |||
[blog post](https://beam.apache.org/blog/python/typing/2020/03/06/python-typing.html). | |||
* --direct_num_workers=0 is supported for FnApi. It will set the number of threads/subprocesses to number of cores of the machine executing the pipeline([BEAM-9443](https://issues.apache.org/jira/browse/BEAM-9443)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is added to 2.21.0, please let me know if the branch is already cut, I can move it to 2.22.0 if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The branch is cut, please move to 2.22.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CHANGES.md
Outdated
@@ -67,6 +67,7 @@ | |||
[Ensuring Python Type Safety](https://beam.apache.org/documentation/sdks/python-type-safety/) | |||
and an upcoming | |||
[blog post](https://beam.apache.org/blog/python/typing/2020/03/06/python-typing.html). | |||
* --direct_num_workers=0 is supported for FnApi. It will set the number of threads/subprocesses to number of cores of the machine executing the pipeline([BEAM-9443](https://issues.apache.org/jira/browse/BEAM-9443)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The branch is cut, please move to 2.22.0
CHANGES.md
Outdated
@@ -67,6 +67,7 @@ | |||
[Ensuring Python Type Safety](https://beam.apache.org/documentation/sdks/python-type-safety/) | |||
and an upcoming | |||
[blog post](https://beam.apache.org/blog/python/typing/2020/03/06/python-typing.html). | |||
* --direct_num_workers=0 is supported for FnApi. It will set the number of threads/subprocesses to number of cores of the machine executing the pipeline([BEAM-9443](https://issues.apache.org/jira/browse/BEAM-9443)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* --direct_num_workers=0 is supported for FnApi. It will set the number of threads/subprocesses to number of cores of the machine executing the pipeline([BEAM-9443](https://issues.apache.org/jira/browse/BEAM-9443)). | |
* --direct_num_workers=0 is supported for FnApi runner. It will set the number of threads/subprocesses to number of cores of the machine executing the pipeline([BEAM-9443](https://issues.apache.org/jira/browse/BEAM-9443)). |
|
||
## Highlights | ||
|
||
* New highly anticipated feature X added to Python SDK ([BEAM-X](https://issues.apache.org/jira/browse/BEAM-X)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove these placeholders? ie keep the section headers but remove "feature X..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see problems here. It's good to provide a sample when there is no entry. Contributors will overwrite the placeholder when they add something new.
The failures are not related to the PR, so merge it. |
R: @ibzib
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.