[BEAM-10024] Mark testOutputTimestampDefault with UsesUnboundedPColle… #11739
Conversation
…ctions annotation.
|
Run Spark ValidatesRunner |
| @@ -3539,6 +3539,7 @@ public void onTimer() {} | |||
| @Category({ | |||
| ValidatesRunner.class, | |||
| UsesTimersInParDo.class, | |||
| UsesUnboundedPCollections.class, | |||
There was a problem hiding this comment.
It might be better to follow-up with the PR author as to why they added .setIsBoundedInternal(IsBounded.UNBOUNDED) instead and have different variants of runners execute the test (batch/streaming/...).
There was a problem hiding this comment.
I think it was so that it would run on a streaming runner (especially the Dataflow runner). ValidatesRunner tests that use TestStream don't run on Dataflow today I believe, and we have several other places in our test codebase where this pattern is used.
There was a problem hiding this comment.
I split the test into batch and streaming variants, PTAL
There was a problem hiding this comment.
ping @lukecwik @reuvenlax
|
Run Samza ValidatesRunner |
|
Run Spark ValidatesRunner |
|
I am merging this 'eagerly' because it is already two weeks of the VR suite broken and I don't see a stronger reason to not do it, if someone thinks something else is missing please let a comment. |
…ctions annotation.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.